[Refactor] PagedKVCache spec for MLC-LLM #3203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annanyapr
requested review from
MasterJH5574
and removed request for
MasterJH5574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have used the new spec for PagedKVCache for mlc-llm model definition. I have also removed the usage of the MLC-LLM PagedKVCache and relied on the TVM version everywhere. We don't need to change much as the new PagedKVCache spec is the child of the Object spec so all the earlier implementation is still valid. This PR should be merged only after apache/tvm#17837 is merged.